Update Bottom Sheet #1198
Merged
Update Bottom Sheet #1198
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFA11
commented
Jul 17, 2024
|
Hey @ThusSpokeNomad, looks like something lead to the reformatting in the whole data file. Usually, we would need to revert those changes, but in this case, it looks like we can close the PR, since given library is already present in the directory: We have a deduplicate mechanism, which should fail the CI, but it did not work in this case for some reason, going to investigate the checks. |
|
hey @Simek nice catch, I didn't see that! |
Simek
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Why & how
Update bottom sheet (as requested by @brentvatne over here: reactwg/react-native-new-architecture#167 (reply in thread))
✅ Checklist
react-native-libraries.jsonreact-native-libraries.json