Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build nightly with the JDK 23 release branch (24.1) #750

Closed

Conversation

jerboaa
Copy link
Collaborator

@jerboaa jerboaa commented Jun 25, 2024

Partial fix for #749. This switches nightly builds to use the new mandrel/24.1 branch (currently broken). CI builds for 24.2 (JDK 24) to follow once adoptium/api.adoptium.net#1077 is resolved.

@jerboaa jerboaa requested a review from zakkak June 25, 2024 08:17
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 25, 2024
@jerboaa jerboaa added this to the 24.1.0.0-Final milestone Jun 25, 2024
@jerboaa
Copy link
Collaborator Author

jerboaa commented Jun 25, 2024

Mandrel build fails because we need a backport of oracle#9078 to be able to build with JDK 23+26 and better. PR for that in progress.

Edit: PR with the backport to 24.1 is here: #751

@jerboaa
Copy link
Collaborator Author

jerboaa commented Jun 25, 2024

@zakkak Not sure if this is the right approach. Maybe we should keep nightly on graal/master and change to JDK 24? And then possibly adding JDK 23 based builds test to the weekly schedule. Thoughts?

Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zakkak Not sure if this is the right approach. Maybe we should keep nightly on graal/master and change to JDK 24? And then possibly adding JDK 23 based builds test to the weekly schedule. Thoughts?

Yes, that's the way we usually do it as we don't expect many changes on the release branch.

So we need to:

  1. move the 23-based builds to the weekly pipeline
  2. Create new issues for CI reporting (using @mandrel-bot) and use them in the corresponding jobs
  3. update the jdk version in the nightly pipeline

@jerboaa
Copy link
Collaborator Author

jerboaa commented Jun 26, 2024

@zakkak Not sure if this is the right approach. Maybe we should keep nightly on graal/master and change to JDK 24? And then possibly adding JDK 23 based builds test to the weekly schedule. Thoughts?

Yes, that's the way we usually do it as we don't expect many changes on the release branch.

OK.

2. Create new issues for CI reporting (using @mandrel-bot) and use them in the corresponding jobs

Any guidance as to how to do that?

@jerboaa
Copy link
Collaborator Author

jerboaa commented Jun 26, 2024

Withdrawing this PR as we'll fix this with a different approach.

@jerboaa jerboaa closed this Jun 26, 2024
@zakkak
Copy link
Collaborator

zakkak commented Jun 26, 2024

Any guidance as to how to do that?

I open a new private window in firefox and login using the mandrel-bot credentials. You should have access to these through our shared vault (if not let me know in private).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants