-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.1] Backport JDK 23+26 upgrade changes to 24.1 release tree #751
Conversation
CI run with this: https://github.com/graalvm/mandrel/actions/runs/9660331969 |
3bc452d
to
22e2e94
Compare
@zakkak Could you please take a look? This would unbreak the JDK 23-based builds from the release branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jerboaa!
In general I am in favor of cherry picking the commits with the -x
flag to make it easier to track backports back to the original commits but in this case the original PR consists of 44 commits...
So I am thinking that in this case maybe we could amend the commit message to include the commit messages and hashes of the backported commits and rebase? (skipping the empty automated ones)
Please let me know if you would like me to take this over.
Futhermore, oracle#9078 is most probably going to be backported upstream as well so this is just an "early backport" for us to get testing working again, right? |
Yes, it'll be an early backport.
Wow, that seems like a bit of a waste of time in this case. I'm thinking of pushing this, then do
If you feel like it's worth going this route of cherry-picking 44 commits then yes, please, take it over. |
Closing in favor of #757 |
Backport oracle#9078