Support publishing using Ivy

[maczikasz]

This PR is aimed to support publishing to sonatype nexus using IvyPublication

The change adds extra configuration options for ivy and hooks into ivy-publish as well as maven-publish to create the required tasks for pushing to sonatype

The compat tests are ran for both publish plugin typesm only duplicated where the artifact patterns are different for the assertions

There are 2 end to end test repositories that are currently hosted under my github, these could be moved over to any of the maintainer's github

Readme is also updated

This PR builds on the initial work of @marcphilipp

[maczikasz]

Removed some accidental reformats

[szpak]

Just a few details, but in general it looks good.

[maczikasz]

@szpak There are some new changes that we discussed with @marcphilipp

Moving publicationType and ivyRepositoryPattern to the NexusRepository level instead of the extension level

[szpak]

It seems to be ready. Thanks @maczikasz for your contribution!

I need some time to review the other 2.0.0 candidates, but I will try to merge & release it "soon".

[szpak]

Btw, do you guys have anything in mind which could/should be done before 2.0.0 (as a breaking change, in addition to dropping "build support" for <JDK 11)?

[maczikasz]

It seems to be ready. Thanks @maczikasz for your contribution!

I need some time to review the other 2.0.0 candidates, but I will try to merge & release it "soon".

Thanks for reviewing. If you merge and maybe will there be a snapshot or pre-release version that we could use before release? We have time to wait for the release before needing this in our side for production, but would be really cool to try it out before

[szpak]

I moved your changes to the other branch and tested e2e. I had to do some minor adjustments (1, 2) in e2e projects, but it the end, all of them passed: https://github.com/gradle-nexus/publish-plugin/actions/runs/5149777155/jobs/9273194799

I also forked them in the gradle-nexus group to make a possibility to push the changes (however, I still plan to test the "e2e projects inline in the main repo" idea). Of course, extracting the core e2e logic still holds true :-).

[szpak]

If you merge and maybe will there be a snapshot or pre-release version that we could use before release?

Sure, I just have to merge some long awaiting PRs and it takes time due to the CI builds. Probably I could merge them locally to on another branch to merge it at once.

[szpak]

If you merge and maybe will there be a snapshot or pre-release version that we could use before release? We have time to wait for the release before needing this in our side for production, but would be really cool to try it out before

@maczikasz It's quite harder than I initially thought :-/. I completely forgot that in this project there is no publishing to Maven Central configured and I cannot send snapshots there. Is it possible to release a snapshot version of the plugin to plugins.gradle.org? Or you had anything else in mind (e.g. publishing 2.0.0-rc1 as a regular version)?

[TWiStErRob]

This works on Gradle 8.2-milestone-1, but breaks on 8.2-rc-1:
https://github.com/gradle-nexus/publish-plugin/actions/runs/5162790263/jobs/9300726822#step:5:80

[TWiStErRob]

@szpak others do publish rcs like that: https://plugins.gradle.org/plugin/org.ajoberstar.stutter, even Gradle itself https://plugins.gradle.org/plugin/com.gradle.plugin-publish

[szpak]

This works on Gradle 8.2-milestone-1, but breaks on 8.2-rc-1: https://github.com/gradle-nexus/publish-plugin/actions/runs/5162790263/jobs/9300726822#step:5:80

Good catch, thanks @TWiStErRob . It seems to be an another issue with the new tests for Ivy. I added build scan to that workflow and the reported error is not something that I expected :-/

> Task :initializeMyNexusStagingRepository	
Created staging repository 'orgexample-42' at http://localhost:46845/repositories/orgexample-42/content/	
	
> Task :publishIvyCustomPublicationToMyNexusRepository FAILED	
	
FAILURE: Build failed with an exception.	
	
* What went wrong:	
Execution failed for task ':publishIvyCustomPublicationToMyNexusRepository'.	
> Failed to publish publication 'ivyCustom' to repository 'myNexus'	
   > Could not PUT 'http://localhost:46845/org/example/sample/0.0.1/sample-0.0.1.jar'. Received status code 404 from server: Not Found

@maczikasz Could there be any general regressions in the recent code in master?

[TWiStErRob]

Note: there's one mention of Ivy in the release notes, however that issue was also included in milestone-1's release notes. Ref https://docs.gradle.org/8.2-rc-1/release-notes.html

[maczikasz]

Sorry guys for missing the notifications checking now the failures

[szpak]

@maczikasz I reran it with 8.2-rc-2 and it still fails:
https://github.com/gradle-nexus/publish-plugin/actions/runs/5204024064/jobs/9387675227#step:6:123
https://gradle.com/s/lvky37dvx5uyg

[maczikasz]

thanks @szpak

Yes, I know what the issue is, it seems that the url is cached in the DefaultIvyArtifactRepository and since we are setting a lazy provider the first value that returns is used. We create the staging repos at a later task hence the staging repo url is never used to publish the artifacts.

I raised it internally, I have managed to do a very (VERY) hacky solutions to get the test green, but I need a better way, and also to understand if this is intended or not

[szpak]

@maczikasz To give you a chance to test the Ivy functionality in a real usage, I've just released 2.0.0-rc-1 to the portal. We still plan some minor changes (and maybe in the meantime you will find a less hacky solution for the url issue ;-) ), but please let us know, if it works for you at all.

[maczikasz]

@szpak I have finished testing the ivy publication with 2.0.0.-rc-1 and everything seems to work as expected, I have managed to release things to sonatype and use it subsequently. Thanks a lot for your support on this