bump terraform provider version to v3.3.0 #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 198
Lines ? 29396
Branches ? 0
======================================
Hits ? 0
Misses ? 29396
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joeyorlando
commented
Jul 8, 2024
Makefile
Outdated
There was a problem hiding this comment.
main change + that in go.mod/go.sum
joeyorlando
commented
Jul 8, 2024
| "grafana_oncall_outgoing_webhook": ReplaceGroupWords("oncall", 1), | ||
| "grafana_oncall_route": ReplaceGroupWords("oncall", 1), | ||
| "grafana_oncall_schedule": ReplaceGroupWords("oncall", 1), | ||
| "grafana_oncall_user_notification_rule": ReplaceGroupWords("oncall", 1), |
|
I'm not entirely sure if ❯ make generate
15:12:51 [ .. ] generating provider schema for grafana/grafana 3.3.0
15:12:51 [ OK ] generating provider schema for grafana/grafana 3.3.0
15:12:51 [ .. ] verify go modules dependencies have expected content
all modules verified
15:12:53 [ OK ] go modules dependencies verified
15:12:53 [WARN] the source directory is not relative to the GOPATH at /Users/joeyorlando/go or you are you using symlinks. The build might run into issue. Please move the source directory to be at /Users/joeyorlando/go/src/github.com/grafana/crossplane-provider-grafana
15:12:54 [ .. ] go generate linux_arm64
Generated 48 resources!
angryjet: error: error loading packages using pattern ./...: /Users/joeyorlando/coding/grafana/crossplane-provider-grafana/apis/cloud/v1alpha1/zz_generated.managed.go:11:11: undefined: APIKey
exit status 1
apis/generate.go:31: running "go": exit status 1
15:13:12 [FAIL]
make[1]: *** [go.generate] Error 1
make: *** [generate] Error 2 |
julienduchesne
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Closes grafana/oncall#4410