Add ability to manage user notification policy resources via Terraform and Crossplane #4410
Assignees
Labels
Comments
|
The current version of Grafana OnCall, at the time this issue was opened, is v1.5.1. If your issue pertains to an older version of Grafana OnCall, please be sure to list it in the PR description. Thank you 😄! |
|
NOTE: once this issue is completed we can probably close #1193 |
|
This is currently blocked (see conversation here) |
joeyorlando
changed the title
3 tasks
joeyorlando
added a commit
that referenced
this issue
Jul 5, 2024
# What this PR does Related to #4410 The changes in this PR are a prerequisite to grafana/terraform-provider-grafana#1653. See the conversation [here](https://raintank-corp.slack.com/archives/C04JCU51NF8/p1719806995902499?thread_ts=1719520920.744319&cid=C04JCU51NF8) for more context on why we decided to move away from always creating default personal notification rules for users. ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes.
This was referenced Jul 8, 2024
joeyorlando
added a commit
that referenced
this issue
Jul 9, 2024
…#4635) # What this PR does This is a follow-up PR to #4628. As @Ferril pointed out, there was a slight issue in `apps.alerts.tasks.notify_user.perform_notification` method when using a "fallback"/default user notification policy. This is because the `log_record_pk` arg passed into `perform_notification` will fetch the `UserNotificationPolicyLogRecord` object, but that object will have a `notification_policy` set to `None` (because there's no persistent `UserNotificationPolicy` object to refer to). Instead we now pass in a second argument to `perform_notification`, `use_default_notification_policy_fallback`. If this is true, simply grab the transient/in-memory `UserNotificationPolicy` and use that inside of this task Related to #4410 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What would you like to see!
As the title mentions, it would be handy to be able to manage a user's personal notification policies via Terraform.
Product Area
Terraform
Anything else to add?
No response
The text was updated successfully, but these errors were encountered: