Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statsd: update about removal #1801

Merged
merged 1 commit into from
Nov 8, 2024
Merged

statsd: update about removal #1801

merged 1 commit into from
Nov 8, 2024

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Nov 7, 2024 •
edited
Loading

What?

We document the change from grafana/k6#3849

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

@olegbespalov olegbespalov requested review from a team and removed request for a team November 7, 2024 09:31
@olegbespalov olegbespalov mentioned this pull request Nov 7, 2024
Closed
33 tasks
heitortsergent
heitortsergent approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@olegbespalov olegbespalov merged commit bfab0e2 into main Nov 8, 2024
3 of 4 checks passed
@olegbespalov olegbespalov deleted the feat/statsd-removal branch November 8, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanlopez joanlopez joanlopez approved these changes

@heitortsergent heitortsergent heitortsergent approved these changes

@oleiade oleiade Awaiting requested review from oleiade oleiade is a code owner automatically assigned from grafana/k6-core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olegbespalov @heitortsergent @joanlopez