-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes statsd output #3849
Removes statsd output #3849
Conversation
7814527
to
e5954b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But am not certain what is going on with windows packaging
Looks like it was a temporary error, something wrong with the NuGet backend made it impossible to download & install one of the dependencies we use for packaging: [NuGet] Response status code does not indicate success: 503 (Service Unavailable: Back-end server is at capacity). I just clicked on retry, and it worked now. Apparently they managed whatever was wrong with their backend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the tiny typo, it looks good! 🎉
Co-authored-by: Joan López de la Franca Beltran <5459617+joanlopez@users.noreply.github.com>
What?
Removes StatsD output from k6 in favor of https://github.com/LeonAdato/xk6-output-statsd
Why?
An external extension exists https://github.com/LeonAdato/xk6-output-statsd.
Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
#3848
Closes #2982