-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit the end-of-iteration metrics outside of the networking and JS code #1250
Labels
evaluation needed
proposal needs to be validated or tested before fully implementing it in k6
executors
maintenance
refactor
Comments
Hi, I would like to work on this issue. |
@Shehab7osny, I've assigned you, let us know if you have any questions or problems with this. |
@na-- Thanks, I will start working on this issue. |
Sure, though you can also just ask any questions here as well 🤷♂️ |
na--
added
evaluation needed
proposal needs to be validated or tested before fully implementing it in k6
and removed
hacktoberfest
labels
Nov 3, 2021
This was referenced Dec 3, 2021
mstoykov
added a commit
that referenced
this issue
Aug 22, 2024
This is an artifact of both data sent/received and iterations being in the same SampleContainer. So where one was emitted we needed to emit the other. That hasn't been a requirement for a while as evident by the dropping of NetTrail with no breaking in outputs. This also stops emitting `iteration_duration` in not default functions (teardown, setup) as it already does for `iterations`. Closes #1605 Part of #1250
5 tasks
mstoykov
added a commit
that referenced
this issue
Aug 22, 2024
…3908) This is an artifact of both data sent/received and iterations being in the same SampleContainer. So where one was emitted we needed to emit the other. That hasn't been a requirement for a while as evident by the dropping of NetTrail with no breaking in outputs. This also stops emitting `iteration_duration` in not default functions (teardown, setup) as it already does for `iterations`. Closes #1605 Part of #1250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
evaluation needed
proposal needs to be validated or tested before fully implementing it in k6
executors
maintenance
refactor
After #1203, the
iterations
metric is emitted as a part of thenetext.NetTrail
struct, together with theiteration_duration
,data_received
, anddata_sent
metrics. This somewhat makes sense, however it doesn't make sense to call that metric sample containernetext.NetTrail
(since only 50% of its metrics are network-related). It also doesn't make sense to emit these metrics from the JS code - since they relate to iterations, they should be emitted by the thing that controls iterations...So, after #1007 is merged, we should refactor the code, probably like this:
SampleContainer
something else,IterationMetrics
or something like thatnetext.Dialer
would still be needed, but it will only be concerned with thedata_sent
anddata_received
metrics, which would then be re-packaged in that new structThe text was updated successfully, but these errors were encountered: