Drop NetTrail - emit iterations metrics in runner instead of dialer #3908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an artifact of both data sent/received and iterations being in the same SampleContainer. So where one was emitted we needed to emit the other. That hasn't been a requirement for a while as evident by the dropping of NetTrail with no breaking in outputs. This also stops emitting `iteration_duration` in not default functions (teardown, setup) as it already does for `iterations`. Closes #1605 Part of #1250
mstoykov
requested review from
olegbespalov and
joanlopez
and removed request for
a team
execution/scheduler_ext_test.go
Outdated
| if v, ok := tags["customTag"]; ok && v == "value" { | ||
| gotNetTrailTag = true | ||
| for _, s := range sample.GetSamples() { | ||
| if s.Metric.Name == metrics.DataSentName && !gotNetTrailTag { |
There was a problem hiding this comment.
nit: after the change, this gotNetTrailTag could confuse
lib/netext/dialer.go
Outdated
| @@ -69,17 +69,14 @@ func (d *Dialer) DialContext(ctx context.Context, proto, addr string) (net.Conn, | |||
| return conn, err | |||
| } | |||
|
|
|||
| // GetTrail creates a new NetTrail instance with the Dialer | |||
| // Sample creates a new NetTrail instance with the Dialer | |||
There was a problem hiding this comment.
How about naming this something like ReadsWritesSamples or IOSamples, something more precise? Also, a method comment not longer valid 😢
There was a problem hiding this comment.
I meant it more like hte verb "sample" as in dialer samples whatever it has to sample and returns it. But it isn't a thing we usually do so I had it renamed
olegbespalov
approved these changes
Aug 22, 2024
joanlopez
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Drop the NetTrail container and emit iterations metric in runner instead of in Dialer.
Also fix #1605
Why?
As part of looking over issues I found #1250 which has some additional work required. But dropping the specific NetTrail and moving the code around was really simple.
FIxing some of the test took a bit more time :(
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
#1250
#1605