Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop common.Bind and other context-based deprecated utils #2448

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Drop common.Bind and other context-based deprecated utils #2448

merged 2 commits into from
Mar 17, 2022

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Mar 17, 2022 •
edited
Loading

Closes #2385
Closes #2428

@codebien codebien requested a review from mstoykov March 17, 2022 09:40
@github-actions github-actions bot requested a review from na-- March 17, 2022 09:40
@mstoykov
Copy link
Contributor

@codebien I think you will need to fix #2428 as well

@codebien codebien self-assigned this Mar 17, 2022
@codebien codebien added the documentation-needed A PR which will need a separate PR for documentation label Mar 17, 2022
@codebien
Copy link
Contributor Author

@mstoykov xk6-tests updated now

na--
na-- reviewed Mar 17, 2022
View reviewed changes
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I am pretty sure we can also easily remove BindToGlobal(), this is the only place it's used as far as I can see:

k6/js/bundle.go

Lines 341 to 344 in 03e938d

unbindInit := common.BindToGlobal(rt, map[string]interface{}{
"require": init.Require,
"open": init.Open,
})

@na-- na-- added this to the v0.38.0 milestone Mar 17, 2022
@mstoykov
Copy link
Contributor

I think we can do that in a separate PR @na-- - there also likely will be other changes in js and common after this changes

na--
na-- approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough 🤷‍♂️ @codebien, can you please open a separate v0.38.0 issue or PR about that? 🙏

@codebien codebien merged commit 869a3fb into master Mar 17, 2022
@codebien codebien deleted the drop-bind branch March 17, 2022 12:51
@codebien
Copy link
Contributor Author

@na-- Sure, I'm already on it

@codebien codebien mentioned this pull request Mar 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@na-- na-- na-- approved these changes

@mstoykov mstoykov mstoykov approved these changes

Assignees

@codebien codebien

Labels
documentation-needed A PR which will need a separate PR for documentation
Projects
None yet
Milestone
v0.38.0
Development

Successfully merging this pull request may close these issues.

xk6 integration tests are using old JS module and metrics APIs Drop common.Bind and context-based utils
3 participants
@codebien @mstoykov @na--