Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop BindToGlobal #2451

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Drop BindToGlobal #2451

merged 2 commits into from
Mar 18, 2022

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Mar 17, 2022

Context: #2448 (review)

@na-- na-- added this to the v0.38.0 milestone Mar 17, 2022
@codebien codebien marked this pull request as ready for review March 18, 2022 12:04
@codebien codebien requested a review from na-- March 18, 2022 12:05
olegbespalov
olegbespalov previously approved these changes Mar 18, 2022
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mstoykov
mstoykov previously approved these changes Mar 18, 2022
@codebien
Copy link
Contributor Author

I force-pushed for triggering the cla check, green CI now

@codebien codebien merged commit c0a8f56 into master Mar 18, 2022
@codebien codebien deleted the drop-bind-global branch March 18, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants