Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golang versions convention #3443

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Golang versions convention #3443

merged 3 commits into from
Nov 7, 2023

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Nov 7, 2023

What?

Writes down the information about the golang updates convention.

Why?

To have this written down.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Dependencies.md Outdated Show resolved Hide resolved
mstoykov
mstoykov previously approved these changes Nov 7, 2023
Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com>
codebien
codebien previously approved these changes Nov 7, 2023
Dependencies.md Outdated Show resolved Hide resolved
Dependencies.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6dc5783) 73.35% compared to head (0219ccf) 73.27%.

❗ Current head 0219ccf differs from pull request most recent head 86b7dd1. Consider uploading reports for the commit 86b7dd1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3443      +/-   ##
==========================================
- Coverage   73.35%   73.27%   -0.08%     
==========================================
  Files         261      259       -2     
  Lines       19742    19737       -5     
==========================================
- Hits        14481    14462      -19     
- Misses       4367     4376       +9     
- Partials      894      899       +5     
Flag Coverage Δ
ubuntu 73.27% <ø> (+<0.01%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Dependencies.md Outdated Show resolved Hide resolved
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
@olegbespalov olegbespalov added this to the v0.48.0 milestone Nov 7, 2023
@olegbespalov olegbespalov merged commit 5e861ed into master Nov 7, 2023
15 of 18 checks passed
@olegbespalov olegbespalov deleted the chore/golang-versions branch November 7, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants