Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golang versions convention #3443

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Golang versions convention #3443

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0ea392
Golang versions convention
olegbespalov Nov 7, 2023
19814cd
Apply suggestions from code review
olegbespalov Nov 7, 2023
86b7dd1
Apply suggestions from code review
olegbespalov Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Dependencies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ As the stability of any k6 release is pretty essential, this should be done only

The latter also serves as a time to open/close issues that are related to the updates. There might be a bug fix for an open issue - we should test it and close the issue. Or there might be new functionality that can be used - probably an issue should be open.

## Golang versions
olegbespalov marked this conversation as resolved.
Show resolved Hide resolved

We aim to support a building of the k6 binary with the two latest versions of golang, which reflects the support policy of the go team.
olegbespalov marked this conversation as resolved.
Show resolved Hide resolved
olegbespalov marked this conversation as resolved.
Show resolved Hide resolved

## Exceptions

There are some dependencies that we really don't use all that much, intend on removing and as a general note don't need anything else from them. Given that we currently have no problems that updates will fix - we prefer to not update them as not to introduce bugs. Also, for some they bring additional dependencies that we do not want, which is just one more reason not to update them.
Expand All @@ -40,8 +44,7 @@ List (as of March 2022):

## How to do it


Currently, I will recommend using [modtools](https://github.com/dop251/modtools).
For updating dependencies we recommend to use [modtools](https://github.com/dop251/modtools).

Running `modtools check --direct-only` will give you a list of packages that aren't frozen (the ones above in the exceptions). Alternatively just running `go get <dependency>` for each direct dependency, which also will tell you if there was an update.

Expand Down