Fix tls min version in tests with go 1.22 #3870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of 1.22 minimum tls version by default is now 1.2, but the test didn't specify lower one, even though they are testing exactly that.
mstoykov
requested review from
codebien and
olegbespalov
and removed request for
a team
olegbespalov
approved these changes
Jul 23, 2024
joanlopez
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As part of 1.22 minimum tls version by default is now 1.2, but the test didn't specify lower one, even though they are testing exactly that.
Why?
While we still haven't set the go directive in go.mod ot 1.22 - we will do it one day and it will be better if things to fail then.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)