Improve 'Mimir / Reads resources' dashboard to work with read-write deployment mode #3504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eployment mode Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
fix-other-resources-dashboards-with-read-write-deployment-mode
branch
from
a099ac9 to
338c2f6
Compare
pracucci
commented
Nov 23, 2022
| memory_working_usage: | ||
| ||| | ||
| node_memory_MemTotal_bytes{%(namespace)s,%(instanceLabel)s=~".*%(instanceName)s.*"} |
There was a problem hiding this comment.
Note to reviewers: the .* prefix and suffix shouldn't be hardcoded in the query, but part of instanceName. For this reason, I moved it to $._config.instance_names.
3 tasks
pracucci
added a commit
that referenced
this pull request
Nov 23, 2022
Signed-off-by: Marco Pracucci <marco@pracucci.com>
3 tasks
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
deleted the
fix-other-resources-dashboards-with-read-write-deployment-mode
branch
|
Hello @pracucci!
Please, if the current pull request addresses a bug fix, label it with the |
3 tasks
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
…eployment mode (grafana#3504) * Improve 'Mimir / Reads resources' dashboard to work with read-write deployment mode Signed-off-by: Marco Pracucci <marco@pracucci.com> * Add CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Similarly to the PR #3497, in this PR I'm improving the 'Mimir / Reads resources' dashboard to work with read-write deployment mode too.
In details:
.*.*suffix in the instance names regex used in baremetal dashboards$._config.instance_namesand$._config.container_namesin all CPU/memory/disk panels (networking panels will be addressed in a follow up PR)containerGoHeapInUsePanel()everywhere (instead of the deprecatedgoHeapInUsePanel())Out of scope of this PR:
Screenshots of microservices deployment:
Screenshots of read-write deployment:
Which issue(s) this PR fixes or relates to
Part of #3361
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]