Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve networking panels to work with read write deployment mode #3519

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Nov 24, 2022

What this PR does

Follow up the work done in #3497 and #3504, it this PR I'm addressing the "networking" dashboards. In details:

  • Added "Summary" row both to "Writes networking" and "Reads networking" dashboards
  • Changed "Inflight requests" and "TCP connections" queries to not match read-write deployment mode when building the panels for a specific component (e.g. "distributor"). This is the same pattern used for "Writes/Reads resources" dashboards too

Example microservices deployment:
Screenshot 2022-11-28 at 10 48 10

Example read-write deployment:
Screenshot 2022-11-28 at 10 48 04

Which issue(s) this PR fixes or relates to

Part of #3361

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pracucci pracucci requested a review from a team as a code owner November 24, 2022 14:33
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsonnet changes make sense to me, but the Summary row is not in the screenshots in the PR description. I tried generating them locally, but the screenshot taker seems to fail right after it reaches "Taking screenshot of mimir-overview-resources"

edit: make mixin-screenshots fails with

Taking screenshot of mimir-overview-resources
node:internal/errors:844
  const err = new Error(message);
              ^

Error: Command failed: pngquant --force --ext '.png' --skip-if-larger --speed 1 --strip --quality 100 /output/overview-resources/mimir-overview-resources.png

    at ChildProcess.exithandler (node:child_process:398:12)
    at ChildProcess.emit (node:events:527:28)
    at maybeClose (node:internal/child_process:1090:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5) {
  code: 99,
  killed: false,
  signal: null,
  cmd: "pngquant --force --ext '.png' --skip-if-larger --speed 1 --strip --quality 100 /output/overview-resources/mimir-overview-resources.png",
  stdout: '',
  stderr: ''
}

Node.js v17.9.1

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci force-pushed the improve-networking-panels-to-work-with-read-write-deployment-mode branch from 72f82de to b2ace8e Compare November 28, 2022 09:47
@pracucci
Copy link
Collaborator Author

jsonnet changes make sense to me, but the Summary row is not in the screenshots in the PR description. I tried generating them locally, but the screenshot taker seems to fail right after it reaches "Taking screenshot of mimir-overview-resources"

The original commit had a bug. The "Summary" row was called "Query-frontend". Then I fixed it, but forgot to update the example screenshots in the PR description. I just updated them.

@pracucci
Copy link
Collaborator Author

I tried generating them locally, but the screenshot taker seems to fail right after it reaches "Taking screenshot of mimir-overview-resources"

I just tried to run make mixin-screenshots and it succeeded. Please reach out to me on Slack, so we can better investigate it.

@pracucci pracucci enabled auto-merge (squash) November 28, 2022 09:55
@pracucci pracucci merged commit 5064c64 into main Nov 28, 2022
@pracucci pracucci deleted the improve-networking-panels-to-work-with-read-write-deployment-mode branch November 28, 2022 10:01
@replay replay mentioned this pull request Nov 28, 2022
37 tasks
replay pushed a commit that referenced this pull request Nov 28, 2022
)

* Improve networking dashboards to work with read-write deployment mode

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Added CHANGELOG entry

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Fixed panel title

Signed-off-by: Marco Pracucci <marco@pracucci.com>

Signed-off-by: Marco Pracucci <marco@pracucci.com>
replay added a commit that referenced this pull request Nov 29, 2022
grafanabot pushed a commit that referenced this pull request Nov 29, 2022
)

* Improve networking dashboards to work with read-write deployment mode

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Added CHANGELOG entry

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Fixed panel title

Signed-off-by: Marco Pracucci <marco@pracucci.com>

Signed-off-by: Marco Pracucci <marco@pracucci.com>
(cherry picked from commit 5064c64)
replay added a commit that referenced this pull request Nov 29, 2022
…yment mode (#3574)

* Improve networking panels to work with read write deployment mode (#3519)

* Improve networking dashboards to work with read-write deployment mode

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Added CHANGELOG entry

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Fixed panel title

Signed-off-by: Marco Pracucci <marco@pracucci.com>

Signed-off-by: Marco Pracucci <marco@pracucci.com>
(cherry picked from commit 5064c64)

* add an empty space

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* Revert "add an empty space"

This reverts commit 8136c97.

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Mauro Stettler <mauro.stettler@gmail.com>
masonmei pushed a commit to udmire/mimir that referenced this pull request Dec 16, 2022
…afana#3519)

* Improve networking dashboards to work with read-write deployment mode

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Added CHANGELOG entry

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Fixed panel title

Signed-off-by: Marco Pracucci <marco@pracucci.com>

Signed-off-by: Marco Pracucci <marco@pracucci.com>
masonmei pushed a commit to udmire/mimir that referenced this pull request Dec 16, 2022
masonmei pushed a commit to udmire/mimir that referenced this pull request Dec 16, 2022
…yment mode (grafana#3574)

* Improve networking panels to work with read write deployment mode (grafana#3519)

* Improve networking dashboards to work with read-write deployment mode

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Added CHANGELOG entry

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Fixed panel title

Signed-off-by: Marco Pracucci <marco@pracucci.com>

Signed-off-by: Marco Pracucci <marco@pracucci.com>
(cherry picked from commit 5064c64)

* add an empty space

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* Revert "add an empty space"

This reverts commit 8136c97.

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Mauro Stettler <mauro.stettler@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants