-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve networking panels to work with read write deployment mode #3519
Improve networking panels to work with read write deployment mode #3519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsonnet changes make sense to me, but the Summary row is not in the screenshots in the PR description. I tried generating them locally, but the screenshot taker seems to fail right after it reaches "Taking screenshot of mimir-overview-resources"
edit: make mixin-screenshots
fails with
Taking screenshot of mimir-overview-resources
node:internal/errors:844
const err = new Error(message);
^
Error: Command failed: pngquant --force --ext '.png' --skip-if-larger --speed 1 --strip --quality 100 /output/overview-resources/mimir-overview-resources.png
at ChildProcess.exithandler (node:child_process:398:12)
at ChildProcess.emit (node:events:527:28)
at maybeClose (node:internal/child_process:1090:16)
at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5) {
code: 99,
killed: false,
signal: null,
cmd: "pngquant --force --ext '.png' --skip-if-larger --speed 1 --strip --quality 100 /output/overview-resources/mimir-overview-resources.png",
stdout: '',
stderr: ''
}
Node.js v17.9.1
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
72f82de
to
b2ace8e
Compare
The original commit had a bug. The "Summary" row was called "Query-frontend". Then I fixed it, but forgot to update the example screenshots in the PR description. I just updated them. |
I just tried to run |
) * Improve networking dashboards to work with read-write deployment mode Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed panel title Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com>
) * Improve networking dashboards to work with read-write deployment mode Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed panel title Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com> (cherry picked from commit 5064c64)
…yment mode (#3574) * Improve networking panels to work with read write deployment mode (#3519) * Improve networking dashboards to work with read-write deployment mode Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed panel title Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com> (cherry picked from commit 5064c64) * add an empty space Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * Revert "add an empty space" This reverts commit 8136c97. Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Mauro Stettler <mauro.stettler@gmail.com>
…afana#3519) * Improve networking dashboards to work with read-write deployment mode Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed panel title Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com>
…mode (grafana#3519)" This reverts commit e352ecb.
…yment mode (grafana#3574) * Improve networking panels to work with read write deployment mode (grafana#3519) * Improve networking dashboards to work with read-write deployment mode Signed-off-by: Marco Pracucci <marco@pracucci.com> * Added CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed panel title Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com> (cherry picked from commit 5064c64) * add an empty space Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * Revert "add an empty space" This reverts commit 8136c97. Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Mauro Stettler <mauro.stettler@gmail.com>
What this PR does
Follow up the work done in #3497 and #3504, it this PR I'm addressing the "networking" dashboards. In details:
Example microservices deployment:
Example read-write deployment:
Which issue(s) this PR fixes or relates to
Part of #3361
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]