Remove "Inflight requests" from object store panels #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
jhesketh
approved these changes
Nov 25, 2022
dimitarvdimitrov
approved these changes
Nov 28, 2022
@dimitarvdimitrov I think "Mimir / Queries" dashboard is a good candidate for such metrics. I would try to fit them there before introducing yet another dashboard. |
replay
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com>
grafanabot
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com> (cherry picked from commit ce49b04)
replay
pushed a commit
that referenced
this pull request
Nov 29, 2022
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com>
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
…rafana#3573) Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com> (cherry picked from commit ce49b04) Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR reverts #2914. As explained in #3324 (comment), this panel is wrong among object store panels because it queries (a) a store-gateway specific metric which (b) tracks the number of inflight
Series()requests in the store-gateway and not the number of inflight requests to the store-gateway.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]