Skip to content

Commit

Permalink
Remove "Inflight requests" from object store panels (grafana#3521)
Browse files Browse the repository at this point in the history 
Signed-off-by: Marco Pracucci <marco@pracucci.com>

Signed-off-by: Marco Pracucci <marco@pracucci.com>
  • Loading branch information
@pracucci
pracucci authored Nov 28, 2022
1 parent 63b656a commit ce49b04
Show file tree
Hide file tree
Showing 10 changed files with 308 additions and 1,192 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
* [ENHANCEMENT] Dashboards: improved "Mimir / Writes resources" and "Mimir / Reads resources" dashboards to work with read-write deployment mode too. #3497 #3504
* [BUGFIX] Dashboards: Fix legend showing `persistentvolumeclaim` when using `deployment_type=baremetal` for `Disk space utilization` panels. #3173
* [BUGFIX] Alerts: Fixed `MimirGossipMembersMismatch` alert when Mimir is deployed in read-write mode. #3489
* [BUGFIX] Dashboards: Remove "Inflight requests" from object store panels because the panel is not tracking the inflight requests to object storage. #3521

### Jsonnet

Expand Down
166 changes: 39 additions & 127 deletions operations/mimir-mixin-compiled-baremetal/dashboards/mimir-alertmanager.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -863,7 +863,7 @@
"renderer": "flot",
"seriesOverrides": [ ],
"spaceLength": 10,
"span": 4,
"span": 3,
"stack": true,
"steppedLine": false,
"targets": [
Expand Down Expand Up @@ -939,7 +939,7 @@
"renderer": "flot",
"seriesOverrides": [ ],
"spaceLength": 10,
"span": 4,
"span": 3,
"stack": false,
"steppedLine": false,
"targets": [
Expand Down Expand Up @@ -1015,95 +1015,7 @@
"renderer": "flot",
"seriesOverrides": [ ],
"spaceLength": 10,
"span": 4,
"stack": false,
"steppedLine": false,
"targets": [
{
"expr": "sum(cortex_bucket_stores_gate_queries_in_flight{cluster=~\"$cluster\", namespace=~\"$namespace\", component=\"alertmanager-storage\"})",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "Total",
"legendLink": null,
"step": 10
}
],
"thresholds": [ ],
"timeFrom": null,
"timeShift": null,
"title": "Inflight requests",
"tooltip": {
"shared": false,
"sort": 0,
"value_type": "individual"
},
"type": "graph",
"xaxis": {
"buckets": null,
"mode": "time",
"name": null,
"show": true,
"values": [ ]
},
"yaxes": [
{
"format": "short",
"label": null,
"logBase": 1,
"max": null,
"min": 0,
"show": true
},
{
"format": "short",
"label": null,
"logBase": 1,
"max": null,
"min": null,
"show": false
}
]
}
],
"repeat": null,
"repeatIteration": null,
"repeatRowId": null,
"showTitle": true,
"title": "Alertmanager Configuration Object Store (Alertmanager accesses)",
"titleSize": "h6"
},
{
"collapse": false,
"height": "250px",
"panels": [
{
"aliasColors": { },
"bars": false,
"dashLength": 10,
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 13,
"legend": {
"avg": false,
"current": false,
"max": false,
"min": false,
"show": true,
"total": false,
"values": false
},
"lines": true,
"linewidth": 1,
"links": [ ],
"nullPointMode": "null as zero",
"percentage": false,
"pointradius": 5,
"points": false,
"renderer": "flot",
"seriesOverrides": [ ],
"spaceLength": 10,
"span": 4,
"span": 3,
"stack": false,
"steppedLine": false,
"targets": [
Expand Down Expand Up @@ -1175,7 +1087,7 @@
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 14,
"id": 13,
"legend": {
"avg": false,
"current": false,
Expand All @@ -1195,7 +1107,7 @@
"renderer": "flot",
"seriesOverrides": [ ],
"spaceLength": 10,
"span": 4,
"span": 3,
"stack": false,
"steppedLine": false,
"targets": [
Expand Down Expand Up @@ -1259,15 +1171,27 @@
"show": false
}
]
},
}
],
"repeat": null,
"repeatIteration": null,
"repeatRowId": null,
"showTitle": true,
"title": "Alertmanager Configuration Object Store (Alertmanager accesses)",
"titleSize": "h6"
},
{
"collapse": false,
"height": "250px",
"panels": [
{
"aliasColors": { },
"bars": false,
"dashLength": 10,
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 15,
"id": 14,
"legend": {
"avg": false,
"current": false,
Expand All @@ -1287,7 +1211,7 @@
"renderer": "flot",
"seriesOverrides": [ ],
"spaceLength": 10,
"span": 4,
"span": 3,
"stack": false,
"steppedLine": false,
"targets": [
Expand Down Expand Up @@ -1351,27 +1275,15 @@
"show": false
}
]
}
],
"repeat": null,
"repeatIteration": null,
"repeatRowId": null,
"showTitle": true,
"title": "",
"titleSize": "h6"
},
{
"collapse": false,
"height": "250px",
"panels": [
},
{
"aliasColors": { },
"bars": false,
"dashLength": 10,
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 16,
"id": 15,
"legend": {
"avg": false,
"current": false,
Expand All @@ -1391,7 +1303,7 @@
"renderer": "flot",
"seriesOverrides": [ ],
"spaceLength": 10,
"span": 4,
"span": 3,
"stack": false,
"steppedLine": false,
"targets": [
Expand Down Expand Up @@ -1463,7 +1375,7 @@
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 17,
"id": 16,
"legend": {
"avg": false,
"current": false,
Expand All @@ -1483,7 +1395,7 @@
"renderer": "flot",
"seriesOverrides": [ ],
"spaceLength": 10,
"span": 4,
"span": 3,
"stack": false,
"steppedLine": false,
"targets": [
Expand Down Expand Up @@ -1555,7 +1467,7 @@
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 18,
"id": 17,
"legend": {
"avg": false,
"current": false,
Expand All @@ -1575,7 +1487,7 @@
"renderer": "flot",
"seriesOverrides": [ ],
"spaceLength": 10,
"span": 4,
"span": 3,
"stack": false,
"steppedLine": false,
"targets": [
Expand Down Expand Up @@ -1659,7 +1571,7 @@
"dashes": false,
"datasource": "$datasource",
"fill": 10,
"id": 19,
"id": 18,
"legend": {
"avg": false,
"current": false,
Expand Down Expand Up @@ -1735,7 +1647,7 @@
"dashes": false,
"datasource": "$datasource",
"fill": 10,
"id": 20,
"id": 19,
"legend": {
"avg": false,
"current": false,
Expand Down Expand Up @@ -1811,7 +1723,7 @@
"dashes": false,
"datasource": "$datasource",
"fill": 10,
"id": 21,
"id": 20,
"legend": {
"avg": false,
"current": false,
Expand Down Expand Up @@ -1902,7 +1814,7 @@
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 22,
"id": 21,
"legend": {
"avg": false,
"current": false,
Expand Down Expand Up @@ -1986,7 +1898,7 @@
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 23,
"id": 22,
"legend": {
"avg": false,
"current": false,
Expand Down Expand Up @@ -2062,7 +1974,7 @@
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 24,
"id": 23,
"legend": {
"avg": false,
"current": false,
Expand Down Expand Up @@ -2150,7 +2062,7 @@
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 25,
"id": 24,
"legend": {
"avg": false,
"current": false,
Expand Down Expand Up @@ -2227,7 +2139,7 @@
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 26,
"id": 25,
"legend": {
"avg": false,
"current": false,
Expand Down Expand Up @@ -2325,7 +2237,7 @@
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 27,
"id": 26,
"legend": {
"avg": false,
"current": false,
Expand Down Expand Up @@ -2426,7 +2338,7 @@
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 28,
"id": 27,
"legend": {
"avg": false,
"current": false,
Expand Down Expand Up @@ -2513,7 +2425,7 @@
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 29,
"id": 28,
"legend": {
"avg": false,
"current": false,
Expand Down Expand Up @@ -2600,7 +2512,7 @@
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 30,
"id": 29,
"legend": {
"avg": false,
"current": false,
Expand Down
Loading

0 comments on commit ce49b04

Please sign in to comment.