Return only samples within the queried start/end time range when executing a remote read request using SAMPLES mode #8463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krajorama
approved these changes
Jun 21, 2024
4 tasks
|
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
…uting a remote read request using SAMPLES mode Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
add-readhints-support-and-fix-TestQuerierRemoteRead
branch
from
5271226
to
11aa2d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
A remote read request executed in SAMPLES mode can return samples outside of the queried range. The reason is that, for performance reasons, in Mimir we don't have a strong guarantee that samples outside the queried time range are filtered out by the
Queryable; at the end, PromQL engine will do it anyway. However, in a remote read request we may save on same returned data by filtering out samples out of the queried time range, which is what I'm proposing in this PR.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.