Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove unused min/max in chunk merge iterator #8464

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

pracucci
Copy link
Collaborator

What this PR does

While working on #8463 I noticed that the chunk merge iterator takes the querier's min/max in input but it's never used. In this PR I'm cleaning it up.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci requested a review from a team as a code owner June 21, 2024 12:55
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's also not used in GEM

@pracucci pracucci merged commit 650fa03 into main Jun 21, 2024
29 checks passed
@pracucci pracucci deleted the remove-unused-min-max-in-chunk-merge-iterator branch June 21, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants