Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Fix cutting by block size and adjust limits #514

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Fix cutting by block size and adjust limits #514

merged 2 commits into from
Feb 14, 2023

Conversation

simonswine
Copy link
Collaborator

  • Fix block size cutting
  • Change thresholds for row group and block target size

@simonswine
Fix block size cutting
592a139 
Now every head table exposes the estimated memory size and the estimated
total size of the data store in memory and within row group segments on
disk. This will fix the usage of block size based cutting
@simonswine
Change thresholds for row group and block target size
88d6b22
@simonswine simonswine force-pushed the 20230210_fix-block-size-cutting branch from 007439c to 88d6b22 Compare February 10, 2023 17:41
@simonswine simonswine changed the title 20230210 fix block size cutting Fix cutting by block size and adjust limits Feb 14, 2023
@simonswine simonswine marked this pull request as ready for review February 14, 2023 16:19
@simonswine simonswine merged commit bcdb179 into main Feb 14, 2023
@simonswine simonswine deleted the 20230210_fix-block-size-cutting branch February 14, 2023 16:39
simonswine added a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
@simonswine
Merge pull request grafana/phlare#514 from grafana/20230210_fix-block…
2f6a978 
…-size-cutting

Fix cutting by block size and adjust limits
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonswine @cyriltovena