This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Use binary search in getSeriesIndex
#621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
approved these changes
Apr 13, 2023
|
Thanks for your review! 💚 💙 💜 💛 ❤️ |
|
I suspect this has introduce a bug. #640 @hi-rustin any quick idea ? |
Rustin170506
added a commit
to Rustin170506/phlare
that referenced
this pull request
Apr 24, 2023
This reverts commit b1a77df.
cyriltovena
pushed a commit
that referenced
this pull request
Apr 24, 2023
This reverts commit b1a77df.
cyriltovena
pushed a commit
that referenced
this pull request
Apr 24, 2023
This reverts commit b1a77df.
cyriltovena
pushed a commit
that referenced
this pull request
Apr 24, 2023
This reverts commit b1a77df.
simonswine
added a commit
to simonswine/phlare
that referenced
this pull request
Apr 26, 2023
* Use binary search in `getSeriesIndex` * Now with a fixed behaviour for nil rowRanges and a related test. Co-authored-by: Rustin <rustin.liu@gmail.com>
simonswine
added a commit
to simonswine/phlare
that referenced
this pull request
Apr 26, 2023
This are additional test cases from the PR grafana#621, which we reverted.
simonswine
added a commit
to simonswine/phlare
that referenced
this pull request
Apr 27, 2023
This are additional test cases from the PR grafana#621, which we reverted.
simonswine
added a commit
that referenced
this pull request
Apr 27, 2023
This are additional test cases from the PR #621, which we reverted.
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
* Use binary search in `getSeriesIndex` * Add a test case, which will trigger the nil row range case --------- Co-authored-by: Christian Simon <simon@swine.de>
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
…rafana/phlare#648) This reverts commit 450d7d7.
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
This are additional test cases from the PR grafana/phlare#621, which we reverted.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove TODO and use the binary search here.