This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Use binary search in getSeriesIndex 2.0
#658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use binary search in `getSeriesIndex` * Now with a fixed behaviour for nil rowRanges and a related test. Co-authored-by: Rustin <rustin.liu@gmail.com>
simonswine
changed the title
getSeriesIndex 2.0
Sounds good to me. It does make the code harder to understand. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back the original pr #621, with the fix for the panic.
It makes the code quite a bit more complicated at best with questionable performance gains.
I have also submitted #659 which adds test cases to cover the actual regression.
@hi-rustin how are you feeling about not merging this