Support configuring mTLS for ingestion in TempoMonolithic CR #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasgerstmayr
force-pushed
the
tempo-monolithic-ingestion-tls
branch
from
2609b5d to
9672b7b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
==========================================
- Coverage 75.30% 74.84% -0.46%
==========================================
Files 78 78
Lines 5741 5800 +59
==========================================
+ Hits 4323 4341 +18
- Misses 1197 1236 +39
- Partials 221 223 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andreasgerstmayr
force-pushed
the
tempo-monolithic-ingestion-tls
branch
2 times, most recently
from
851da4e to
0f1d680
Compare
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr
force-pushed
the
tempo-monolithic-ingestion-tls
branch
from
0f1d680 to
43b5cac
Compare
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
pavolloffay
approved these changes
Jan 31, 2024
| metadata: | ||
| name: custom-ca | ||
| data: | ||
| service-ca.crt: | |
There was a problem hiding this comment.
Valid From: January 19, 2024
Valid To: December 26, 2123
:)
There was a problem hiding this comment.
I assume in 100 years this e2e test will be obsolete :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support configuring mTLS for ingestion in TempoMonolithic CR