Fix mapping tests stale naming bug #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helper function was capturing the "global" test variable instead of the one passed to t.Run(), which was causing every test failure from the helper function to not identify the subtest name.
This is unnecessary now as failing from within the helper function will reference the subtest name.
Use quotes to identify the conflict methods.
inancgumus
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
LGTM 👍 This was a nice catch. IDK how we missed it. Thanks!
One downside of the anonymous interface is it won't get along with custom mappings. As I said here, we can take care of it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the mapping layer tests in order to use the subtest
testing.Treference so the subtest name is identified on failure and therefore there is no need to reference the specific type through reflection.Previous error message on a subtest failure:
Current error message:
Why?
Previous behavior was not correct and required the actual type name specification in the error message through reflection in order to understand which was the failing test.
Checklist