Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mapping tests stale naming bug #1014

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Fix mapping tests stale naming bug #1014

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15527e7
Pass testing.T to mapping test helper function
ka3de Aug 29, 2023
068ab8f
Avoid unnecessary type name reference in mapping test
ka3de Aug 29, 2023
ef9befa
Improve format on mapping test error messages
ka3de Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions browser/mapping_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ func TestMappings(t *testing.T) {
// mapped to the module. so we should not find it in
// the mapped methods.
if _, ok := mapped[m]; cmok && ok {
t.Errorf("method %s should not be mapped", m)
t.Errorf("method %q should not be mapped", m)
}
// a custom mapping with an empty string means that
// the method should not exist on the API.
Expand All @@ -109,15 +109,15 @@ func TestMappings(t *testing.T) {
m = cm
}
if _, ok := mapped[m]; !ok {
t.Errorf("method %s not found", m)
t.Errorf("method %q not found", m)
inancgumus marked this conversation as resolved.
Show resolved Hide resolved
}
// to detect if a method is redundantly mapped.
tested[m] = true
}
// detect redundant mappings.
for m := range mapped {
if !tested[m] {
t.Errorf("method %s is redundant", m)
t.Errorf("method %q is redundant", m)
}
}
}
Expand Down
Loading