Refactor traces attributes #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ka3de
commented
Dec 15, 2023
|
I'm considering whether we should also change the "navigation span" here so the actual span name is |
inancgumus
reviewed
Dec 15, 2023
inancgumus
approved these changes
Dec 15, 2023
Rename traces attributes to better comply with conventions on attribute naming recommended by Open Telemetry.
ka3de
force-pushed
the
refactor/traces-attrs
branch
from
47c98bb
to
25e0572
Compare
ka3de
added a commit
that referenced
this pull request
Dec 15, 2023
Based on discussions in #1140 , a decision was made to, instead of using the URL as the span name for navigation spans, use the word 'navigation' to identify the action, following the same pattern as the rest of the spans. Due to this, and because a navigation span will always have that fixed span name, it is no longer necessary to accept the span name as input for the method.
ka3de
added a commit
that referenced
this pull request
Dec 18, 2023
Based on discussions in #1140 , a decision was made to, instead of using the URL as the span name for navigation spans, use the word 'navigation' to identify the action, following the same pattern as the rest of the spans. Due to this, and because a navigation span will always have that fixed span name, it is no longer necessary to accept the span name as input for the method.
ka3de
added a commit
that referenced
this pull request
Dec 19, 2023
Based on discussions in #1140 , a decision was made to, instead of using the URL as the span name for navigation spans, use the word 'navigation' to identify the action, following the same pattern as the rest of the spans. Due to this, and because a navigation span will always have that fixed span name, it is no longer necessary to accept the span name as input for the method.
ka3de
added a commit
that referenced
this pull request
Dec 19, 2023
Based on discussions in #1140 , a decision was made to, instead of using the URL as the span name for navigation spans, use the word 'navigation' to identify the action, following the same pattern as the rest of the spans. Due to this, and because a navigation span will always have that fixed span name, it is no longer necessary to accept the span name as input for the method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Rename traces attributes.
Why?
To better comply with conventions on attribute naming recommended by Open Telemetry. See docs.
Checklist
Related PR(s)/Issue(s)
#1100