Refactor TraceNavigation #1141
Merged
Refactor TraceNavigation #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ka3de
force-pushed
the
refactor/trace-navigation
branch
from
0151ea9
to
fde592f
Compare
|
Because k6 has merged grafana/k6#3503, our integration tests with |
inancgumus
approved these changes
Dec 19, 2023
Based on discussions in #1140 , a decision was made to, instead of using the URL as the span name for navigation spans, use the word 'navigation' to identify the action, following the same pattern as the rest of the spans. Due to this, and because a navigation span will always have that fixed span name, it is no longer necessary to accept the span name as input for the method.
ka3de
force-pushed
the
refactor/trace-navigation
branch
from
fde592f
to
f5aabb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Based on discussions in #1140 , a decision was made to, instead of using the URL as the span name for navigation spans, use the word 'navigation' to identify the action, following the same pattern as the rest of the spans. Due to this, and because a navigation span will always have that fixed span name, it is no longer necessary to accept the span name as input for the method.
Why?
Even though the traces generated from k6 browser have some particularities to fit our needs, this change and the changes done in #1140 try to make our implementation more compliant with Open Telemetry conventions and recommendations. These changes will also improve traces searches.
Checklist
Related PR(s)/Issue(s)
#1100, #1140