Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor locator.click parse #1164

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Refactor locator.click parse #1164

merged 3 commits into from
Jan 22, 2024

Commits on Jan 19, 2024

  1. Add parseFrameClickOptions 

    This will be used by several of the click APIs to parse the options
using the goja runtime before the core work is done async in a
goroutine off the main event loop thread.
    @ankur22
    ankur22 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    3b1ec6f View commit details
    Browse the repository at this point in the history

  2. Refactor locator.click parse 

    This avoids an issue with using the goja runtime within a promise
outside of the main event loop thread, by moving the parsing of
the option to the main event loop thread.
    @ankur22
    ankur22 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0a67517 View commit details
    Browse the repository at this point in the history

  3. Refactor error return from opts parse 

    It's a lot clearer as to what is going on if the parse error in the
mapping layer for locator.click is returned before the promise is
initiated.
    @ankur22
    ankur22 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0b11010 View commit details
    Browse the repository at this point in the history