Refactor parsing of options for waitForNavigation #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parsing of the options for frame.waitForNavigation has been moved outside of the promise. This change will mitigate any issues when working with the goja runtime with multiple goroutines (goja is not thread safe).
The parsing of the options for page.waitForNavigation has been moved outside of the promise. This change will mitigate any issues when working with the goja runtime with multiple goroutines (goja is not thread safe).
This was referenced Jan 23, 2024
ka3de
approved these changes
Jan 24, 2024
ankur22
changed the title
inancgumus
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor the parsing of the options of
waitForNavigationAPIs so that they are done outside the promise and therefore on the main goja thread.Why?
This will help mitigate issues which can occur when trying to access the goja runtime from multiple goroutines, which can causes panics since the goja runtime is not thread safe.
Checklist
Related PR(s)/Issue(s)
Updates: #1184 & #1185