Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor parsing of options for waitForNavigation #1186

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Refactor parsing of options for waitForNavigation #1186

merged 2 commits into from
Jan 25, 2024

Commits on Jan 23, 2024

  1. Refactor parse out of frame.waitForNavigation 

    The parsing of the options for frame.waitForNavigation has been moved
outside of the promise. This change will mitigate any issues when
working with the goja runtime with multiple goroutines (goja is not
thread safe).
    @ankur22
    ankur22 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    32fc1b5 View commit details
    Browse the repository at this point in the history

  2. Refactor parse out of page.waitForNavigation 

    The parsing of the options for page.waitForNavigation has been moved
outside of the promise. This change will mitigate any issues when
working with the goja runtime with multiple goroutines (goja is not
thread safe).
    @ankur22
    ankur22 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    7ab8dd7 View commit details
    Browse the repository at this point in the history