Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cannot find context error on Dispose #1291

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Fix cannot find context error on Dispose #1291

merged 2 commits into from
Apr 30, 2024

Commits on Apr 29, 2024

  1. Refactor to allow for more error handling

    @ankur22
    ankur22 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    50a3777 View commit details
    Browse the repository at this point in the history

  2. Add error handling for Dispose 

    Dispose can panic when a navigation occurs on a page with an iframe.
The specific error that is returned is "Cannot find context with
specified id". The reason for this error is due to the fact that Chrome
has already cleaned up the associated resource before it receives the
CDP command to release it. Therefore it is safe to handle this error,
log a debug log and carry on with the test.
    @ankur22
    ankur22 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    7e42ae9 View commit details
    Browse the repository at this point in the history