Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cannot find context error on Dispose #1291

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Fix cannot find context error on Dispose #1291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50a3777
Refactor to allow for more error handling
ankur22 Apr 29, 2024
7e42ae9
Add error handling for Dispose
ankur22 Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions common/js_handle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"errors"
"fmt"
"strings"

"github.com/grafana/xk6-browser/k6ext"
"github.com/grafana/xk6-browser/log"
Expand Down Expand Up @@ -84,9 +85,20 @@ func (h *BaseJSHandle) Dispose() {
// context. The reason the context would be closed is due to the
// iteration ending and therefore the associated browser and its assets
// will be automatically deleted.
if !errors.Is(err, context.Canceled) {
k6ext.Panic(h.ctx, "dispose: %w", err)
if errors.Is(err, context.Canceled) {
h.logger.Debugf("BaseJSHandle:Dispose", "%v", err)
return
}
// The following error indicates that the object we're trying to release
// cannot be found, which would mean that the object has already been
// removed/deleted. This can occur when a navigation occurs, usually when
// a page contains an iframe.
if strings.Contains(err.Error(), "Cannot find context with specified id") {
h.logger.Debugf("BaseJSHandle:Dispose", "%v", err)
return
}

k6ext.Panic(h.ctx, "dispose: %w", err)
}
}

Expand Down
Loading