Disable timeout on browser process execution #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the browser launching process to not pass a context with timeout to the actual browser process cmd handle. Currently this was done using as timeout the value set for the browser.timeout option, which should serve a different purpose.
This commit modifies the browser connecting process to not pass a context with timeout to the browser process implementation so its closing handler is not triggered after the set timeout. Currently this was done using as timeout the value set for the browser.timeout option, which should serve a different purpose.
ka3de
force-pushed
the
fix/865-browser-global-timeout
branch
from
a03514c
to
1fa9bfb
Compare
inancgumus
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the browser launching/connecting process to not pass a context with timeout to the actual browser process cmd handle and/or implementation closing handle. Currently this was done using as timeout the value set for the browser.timeout option, which should serve a different purpose.
Instead, it makes the browser process handle and its closing handling method depend on the VU context.
Closes #865.
Closes #864.