chore: upgrade to use node 20 #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b050447 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying with
|
| Latest commit: |
b050447
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f7fc28a7.graph-tooling.pages.dev |
| Branch Preview URL: | https://1499-upgrade-to-node-20.graph-tooling.pages.dev |
enisdenjo
reviewed
Nov 13, 2023
dotansimha
reviewed
Nov 14, 2023
dotansimha
reviewed
Nov 14, 2023
| '@graphprotocol/graph-cli': minor | ||
| --- | ||
|
|
||
| upgrade to Node 20 |
There was a problem hiding this comment.
Is there anything needed from the consumer's point of view? Is anything important worth mentioning?
dotansimha
reviewed
Nov 14, 2023
| @@ -31,7 +31,7 @@ jobs: | |||
| with: | |||
| npmTag: rc | |||
| buildScript: build | |||
| nodeVersion: 16 | |||
| nodeVersion: 20 | |||
There was a problem hiding this comment.
Just a side note, I think at some point we can change this in shared-config; we can read the node-version file and just use it by default
There was a problem hiding this comment.
We can also use a .nvmrc file and point to it during setup-node with node-version-file option.
dotansimha
approved these changes
Nov 14, 2023
enisdenjo
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pnpmversioncloses #1499