Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to use node 20 #1500

Merged
merged 2 commits into from
Nov 15, 2023
Merged

chore: upgrade to use node 20 #1500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe8cce4
chore: upgrade node 20
saihaj Nov 13, 2023
b050447
chore: upgrade pnpm
saihaj Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fluffy-rockets-tickle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@graphprotocol/graph-cli': minor
saihaj marked this conversation as resolved.
Show resolved Hide resolved
---

upgrade to Node 20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything needed from the consumer's point of view? Is anything important worth mentioning?

11 changes: 5 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: the-guild-org/shared-config/setup@main
name: Setup Env
with:
nodeVersion: 18
nodeVersion: 20
packageManager: pnpm

- name: Lint
Expand All @@ -31,16 +31,15 @@ jobs:
strategy:
fail-fast: false
matrix:
# For some reason tests take forever on node 14 so will re-visit in future when we decide what versions to test on
node-version: [16, 18, 20]
node-version: [18, 20, 21]
steps:
- name: Checkout Repository
uses: actions/checkout@v3

- uses: the-guild-org/shared-config/setup@main
name: Setup Env
with:
nodeVersion: 18
nodeVersion: 20
packageManager: pnpm

- name: Setup git user information
Expand Down Expand Up @@ -69,7 +68,7 @@ jobs:
- uses: the-guild-org/shared-config/setup@main
name: Setup Env
with:
nodeVersion: 18
nodeVersion: 20
packageManager: pnpm

- name: Build Packages
Expand All @@ -96,7 +95,7 @@ jobs:
- uses: the-guild-org/shared-config/setup@main
name: Setup Env
with:
nodeVersion: 18
nodeVersion: 20
packageManager: pnpm

- name: Build Packages
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
with:
npmTag: alpha
buildScript: build
nodeVersion: 16
nodeVersion: 20
packageManager: pnpm
secrets:
githubToken: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -31,7 +31,7 @@ jobs:
with:
npmTag: rc
buildScript: build
nodeVersion: 16
nodeVersion: 20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a side note, I think at some point we can change this in shared-config; we can read the node-version file and just use it by default

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also use a .nvmrc file and point to it during setup-node with node-version-file option.

packageManager: pnpm
restoreDeletedChangesets: true
secrets:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Setup environment
uses: the-guild-org/shared-config/setup@main
with:
nodeVersion: 16
nodeVersion: 20
packageManager: pnpm
- name: Set variables
id: vars
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@
},
"license": "(Apache-2.0 OR MIT)",
"private": true,
"packageManager": "pnpm@8.3.1",
"packageManager": "pnpm@8.10.4",
"engines": {
"node": ">=18.0.0",
"pnpm": ">=8"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "CLI for building for and deploying to The Graph",
"license": "(Apache-2.0 OR MIT)",
"engines": {
"node": ">=14"
"node": ">=18"
saihaj marked this conversation as resolved.
Show resolved Hide resolved
},
"bin": {
"graph": "bin/run"
Expand Down
30 changes: 15 additions & 15 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading