Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphiql-react/graphiql] new looks of tabs #3644

Merged
merged 24 commits into from
Aug 7, 2024
Merged

Conversation

dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Jul 4, 2024

I adjusted styles in GraphQL-Hive, and I hope you'll like it to be part of the core graphiql

Screen.Recording.2024-06-28.at.14.00.51.mov

before

Screen.Recording.2024-07-04.at.14.17.21.mov

after

Screen.Recording.2024-07-04.at.14.14.15.mov

Copy link

changeset-bot bot commented Jul 4, 2024

🦋 Changeset detected

Latest commit: bf3a6c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
graphiql Major
@graphiql/react Minor
@graphiql/plugin-code-exporter Major
@graphiql/plugin-explorer Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.85%. Comparing base (676f910) to head (bf3a6c3).
Report is 4 commits behind head on graphiql-v4.

Files Patch % Lines
packages/graphiql/src/components/GraphiQL.tsx 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           graphiql-v4    #3644      +/-   ##
===============================================
- Coverage        60.86%   60.85%   -0.02%     
===============================================
  Files              121      121              
  Lines             5622     5620       -2     
  Branches          1492     1490       -2     
===============================================
- Hits              3422     3420       -2     
  Misses            1748     1748              
  Partials           452      452              
Files Coverage Δ
packages/graphiql-react/src/ui/tabs.tsx 100.00% <100.00%> (ø)
packages/graphiql/src/components/GraphiQL.tsx 67.74% <62.50%> (-0.21%) ⬇️

Copy link
Contributor

github-actions bot commented Jul 4, 2024

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@dimaMachina dimaMachina marked this pull request as ready for review July 4, 2024 12:35
@dimaMachina dimaMachina mentioned this pull request Aug 7, 2024
3 tasks
@dimaMachina dimaMachina changed the base branch from main to graphiql-v4 August 7, 2024 12:51
@dimaMachina dimaMachina merged commit 3c1a345 into graphiql-v4 Aug 7, 2024
14 checks passed
@dimaMachina dimaMachina deleted the new-tabs branch August 7, 2024 13:39
@acao acao mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants