[2] GraphiQL x Vite v5 #3679
[2] GraphiQL x Vite v5 #3679
Conversation
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
🦋 Changeset detectedLatest commit: 80bd1fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest changes of this PR are not available as canary, since there are no linked |
| @@ -83,6 +83,7 @@ function getSchemaUrl() { | |||
| // how you can customize GraphiQL by providing different values or | |||
| // additional child elements. | |||
| const root = ReactDOM.createRoot(document.getElementById('graphiql')); | |||
| const graphqlVersion = GraphiQL.GraphQL.version; | |||
There was a problem hiding this comment.
found how to easily get version of graphql-js without importing package.json or injecting code
| lib: { | ||
| entry: 'src/index.ts', | ||
| fileName: 'index', | ||
| formats: ['cjs', 'es'], |
There was a problem hiding this comment.
do we really need a bundle of cjs version for the next major? or just keep esm?
There was a problem hiding this comment.
It's quite a big step to get rid of cjs, if it doesn't cost you much to keep outputting cjs?
There was a problem hiding this comment.
with dropping cjs we can bundle graphql-toolkit to esm only too and fix #3668
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## graphiql-v4 #3679 +/- ##
============================================
Coverage 60.85% 60.85%
============================================
Files 121 121
Lines 5620 5620
Branches 1490 1490
============================================
Hits 3420 3420
Misses 1748 1748
Partials 452 452
|
closes #2925 #2371 #2638 #2184
I propose to cut v4 alpha release and include this PR and new tabs looks PR #3644
changed exports
graphiql/graphiql.jsremoved non-minified umd bundlegraphiql/graphiql.min.js=>graphiql/dist/index.umd.jsgraphiql/graphiql.css=>graphiql/style.css(addedexportsfield inpackage.json)todos:
import 'graphiql/style.css';[v4] update changeset for changed exports #3700