Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalars: ID and String support for serializing BigInt #3109

Closed
wants to merge 1 commit into from

Conversation

Hkmu
Copy link

@Hkmu Hkmu commented May 17, 2021

Add support to serialize BigInt for String and ID scalar.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 17, 2021

CLA Signed

The committers are authorized under a signed CLA.

@papandreou
Copy link

This would be extremely handy! I'm about to switch to representing ids as bigint in my app, and it results in ID cannot represent a non-string and non-integer value: .... This patch fixes that.

@yaacovCR
Copy link
Contributor

yaacovCR commented Oct 1, 2024

I think it would make sense to use a custom scalar for BigInt a la https://the-guild.dev/graphql/scalars/docs/scalars/big-int

@yaacovCR yaacovCR closed this Oct 1, 2024
@yaacovCR
Copy link
Contributor

yaacovCR commented Oct 1, 2024

I misunderstood, this is for coercion of values from BigInt to string/id, not to int, this is reasonable, see discussion at newer PR #4088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants