Allow for serializing int as BigInt

[JoviDeCroock]

Fixes #3913

In the spec we say that we allow for BigInt as an ID value in here. However in JS we don't support serializing a response value from BigInt to String.

[netlify]

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name	Link
🔨 Latest commit	1318fa5
🔍 Latest deploy log	https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6709121001ee6700088d885e
😎 Deploy Preview	https://deploy-preview-4223--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

• @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
• @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

[yaacovCR]

How does this compare to #4088 ?

[JoviDeCroock]

@yaacovCR #4088 adds full support to Int/... for BigInt however that isn't really specced out compared to ID which explicitly in the spec states BigInt support.

Int stating only 32bit can be seen here and there in astFromValue we seem to return kind.INT for a bigint

[yaacovCR]

Maybe #3109 then? I had closed the earlier PRs in favor of the more comprehensive, but that could have been the less optimal approach.

[JoviDeCroock]

That is indeed similar, that only gets applied to serialize not parseValue, I can add a co-authored-by though as they do deserve credit for this. Thank you for making me aware of this PR, it wasn't linked to the issue so I did not find it

[yaacovCR]

However in JS we don't support serializing a response value from BigInt to String.

Did you mean ID here?

Did we want to support String as well?

[JoviDeCroock]

I meant what it reads, a JS value of type BigInt needs to get transformed to a string, just like we do for Int.

i.e. when my resolver returns { id: BigInt(123) } we need to cast it to "123" which is stated in the spec. https://spec.graphql.org/draft/#sel-FAHXZDCCuCCEBsnL

[yaacovCR]

Now I understand your description better… but I still wonder now that we have opened the bigint box whether we can support it with regards to our string scalar. it would certainly be reasonable to make that a separate PR.