fix: invalid originalError propagation in custom scalars

[stenreijers]

Errors thrown in the parseValue function for custom scalars are not propagated correctly using the originalError variable of the GraphQLError on invalid input. As a result, error codes from the extensions.code are not propagated correctly.

The fix is simple: Replace error.orginalError with error, since error.orginalError does not exist yet.
see:

graphql-js/src/execution/values.ts

Line 134 in 8be83d8

originalError: error.originalError,

I have added test-cases to avoid this problem in the future.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: stenreijers / name: Sten Reijers (bdd24b7, 1219dec)

[netlify]

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name	Link
🔨 Latest commit	a982330
🔍 Latest deploy log	https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/63d8ff12212435000845a830
😎 Deploy Preview	https://deploy-preview-3837--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[stenreijers]

The committers listed above are authorized under a signed CLA.

• ✅ login: stenreijers / name: Sten Reijers (bdd24b7, 1219dec, a982330)

[saihaj]

@stenreijers maybe push an empty commit to retigger the CI ?

[stenreijers]

/easycla

[yaacovCR]

This makes sense as a problem to me and also as the solution.

Another approach could be to introduce a generic cloneError utility that does an appropriate deep clone => but I think that rather than attempting the deep clone, it makes more sense to preserve the error hierarchy appropriately...

[IvanGoncharov]

@stenreijers Thanks for fixing it.
It looks like I made a mistake in 14f260b original coercionError had exactly this behavior:

graphql-js/src/utilities/coerceValue.js

Lines 62 to 82 in 18371cb

	if (isScalarType(type)) {
	// Scalars determine if a value is valid via parseValue(), which can
	// throw to indicate failure. If it throws, maintain a reference to
	// the original error.
	try {
	const parseResult = type.parseValue(value);
	if (parseResult === undefined) {
	return ofErrors([
	coercionError(`Expected type ${type.name}`, blameNode, path),
	]);
	}
	return ofValue(parseResult);
	} catch (error) {
	return ofErrors([
	coercionError(
	`Expected type ${type.name}`,
	blameNode,
	path,
	' ' + error.message,
	error,
	),

graphql-js/src/utilities/coerceValue.js

Lines 214 to 236 in 18371cb

	function coercionError(message, blameNode, path, subMessage, originalError) {
	let fullMessage = message;
	// Build a string describing the path into the value where the error was found
	if (path) {
	fullMessage += ' at value';
	for (const key of pathToArray(path)) {
	fullMessage +=
	typeof key === 'string' ? '.' + key : '[' + key.toString() + ']';
	}
	}
	fullMessage += subMessage ? '.' + subMessage : '.';
	// Return a GraphQLError instance
	return new GraphQLError(
	fullMessage,
	blameNode,
	undefined,
	undefined,
	undefined,
	originalError,
	);

Can you please backport this fix to https://github.com/graphql/graphql-js/tree/16.x.x ?

[stenreijers]

Can you please backport this fix to https://github.com/graphql/graphql-js/tree/16.x.x ?

Please see:
#3838