Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hide menu option on mac #969

Merged
merged 3 commits into from
Feb 23, 2019
Merged

Add hide menu option on mac #969

merged 3 commits into from
Feb 23, 2019

Conversation

lekterable
Copy link
Contributor

Fixes #964

Changes proposed in this pull request:

  • New menu option to hide the application + separator, both visible only on mac

Couldn't find any info regarding the Hide Others electron api tho, please let me know if I've missed it and its implemented.

@grahamb
Copy link

grahamb commented Feb 14, 2019

I'm not familiar with Electron development, but it does appear to have built-in support for hide and hideOthers via the role property on a menu item. https://electronjs.org/docs/api/menu-item

@lekterable
Copy link
Contributor Author

yeah, you're right @grahamb , it was that simple, thanks!
could someone familiar with electron confirm that this will be automatically hidden on windows? I don't have a possibility to test it myself 😞

@huv1k
Copy link
Collaborator

huv1k commented Feb 23, 2019

Thanks for your PR! It will be in the next release 🚀

@huv1k huv1k merged commit e443fdf into graphql:master Feb 23, 2019
@lekterable lekterable deleted the app-hide branch February 23, 2019 12:24
cgxxv pushed a commit to cgxxv/graphql-playground that referenced this pull request Mar 25, 2022
* Add hide menu option on mac

* Add hide others menu option on mac

* Add show all menu option on mac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants