Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Fix timing bug once and for all #4362

Closed
chadwhitacre opened this issue Mar 2, 2017 · 1 comment
Closed

Fix timing bug once and for all #4362

chadwhitacre opened this issue Mar 2, 2017 · 1 comment
Labels
TeamX

Comments

@chadwhitacre
Copy link
Contributor

chadwhitacre commented Mar 2, 2017 •
edited
Loading

#4129 #4290 #4314

@nobodxbodon at #4314 (comment):

Wow this sounds flaky. I guess there's no easy way to create some 'wait' method to listen for element change, and then verify if time elapsed isn't too long?

screen shot 2017-03-02 at 2 04 34 pm
@chadwhitacre chadwhitacre mentioned this issue Mar 25, 2017
Merged
chadwhitacre added a commit that referenced this issue Mar 25, 2017
@chadwhitacre
Remove time.sleep calls from ttw tests
f7e4974 
This should squash #4362. Also:

- adapt to Firefox (`Keys.ENTER` vs `\n`)
- fix js memory leak in notifications (`delete $dialog`)
- only open one browser; reuse between classes
- git ignore geckodriver.log
chadwhitacre added a commit that referenced this issue Mar 25, 2017
@chadwhitacre
Remove time.sleep calls from ttw tests
27202ac 
This should squash #4362. Also:

- adapt to Firefox (`Keys.ENTER` vs `\n`)
- fix js memory leak in notifications (`delete $dialog`)
- only open one browser; reuse between classes
- git ignore geckodriver.log
chadwhitacre added a commit that referenced this issue Mar 25, 2017
@chadwhitacre
Remove time.sleep calls from ttw tests
3abccca 
This should squash #4362. Also:

- adapt to Firefox (`Keys.ENTER` vs `\n`)
- fix js memory leak in notifications (`delete $dialog`)
- only open one browser; reuse between classes
- git ignore geckodriver.log
@chadwhitacre
Copy link
Contributor Author

Calling this done in #4391. 🙈

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
TeamX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chadwhitacre