Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Fix travis failure #4314

Merged
merged 1 commit into from
Feb 22, 2017
Merged

Fix travis failure #4314

merged 1 commit into from
Feb 22, 2017

Conversation

chadwhitacre
Copy link
Contributor

In the grand tradition of #4129 and #4290 ...

@chadwhitacre
Copy link
Contributor Author

@chadwhitacre
Copy link
Contributor Author

@JessaWitzel Ready for review! :)

re: slack

@chadwhitacre
Copy link
Contributor Author

For posterity:

It’s not your fault, it’s a spurious test failure.
I tried fixing it once recently but I guess it wasn’t enough.
The ttw tests (the ones that actually load a browser and click around) are sensitive to subtle timing changes.
Like, how long does it take to load the response after clicking a certain button?
Writing those tests is a balancing act between loooong tests (wait ten seconds after clicking the button), and testing too quickly (wait 10 milliseconds after clicking the button).
And we haven’t found the balance point yet on the particular test that’s failing. 🙂

@nobodxbodon
Copy link
Contributor

Wow this sounds flaky. I guess there's no easy way to create some 'wait' method to listen for element change, and then verify if time elapsed isn't too long?

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Feb 8, 2017

I think that's a good idea, but can we just do this for now? 🙈

@chadwhitacre
Copy link
Contributor Author

Bump (and rebased, was 1157e0d).

@mattbk
Copy link
Contributor

mattbk commented Feb 22, 2017

I'm happy with this.

@chadwhitacre
Copy link
Contributor Author

@mattbk I think you could merge?

@mattbk mattbk merged commit a92bdd3 into master Feb 22, 2017
@mattbk mattbk deleted the smash-bash branch February 22, 2017 22:14
@chadwhitacre
Copy link
Contributor Author

💃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants