Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRA-1444: proxy only required connections #300

Merged
merged 11 commits into from
Mar 29, 2023
Merged

GRA-1444: proxy only required connections #300

merged 11 commits into from
Mar 29, 2023

Conversation

abhishek9686
Copy link
Member

@abhishek9686 abhishek9686 commented Mar 29, 2023

Describe your changes

nm-proxy will only proxy required conns

Provide Issue ticket number if applicable/not in title

Provide link to Netmaker PR if required

Provide testing steps

  • Peers will only be proxied when both of them have proxy enabled
  • Only Relay and relayed will use proxy conn
  • Test ingress, egress,relays with proxy on some of the peers
  • Test Endpoint detection with proxy on

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netclient & Netmaker are awesome.

@abhishek9686 abhishek9686 marked this pull request as draft March 29, 2023 07:00
Copy link
Contributor

@theguy951357 theguy951357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing steps pass
critical list and transition tables pass

@afeiszli afeiszli merged commit ca83080 into develop Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants