Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRA-1444: Proxy only required connections #2149

Merged
merged 3 commits into from
Mar 29, 2023
Merged

GRA-1444: Proxy only required connections #2149

merged 3 commits into from
Mar 29, 2023

Conversation

abhishek9686
Copy link
Member

@abhishek9686 abhishek9686 commented Mar 29, 2023 •
edited
Loading

Describe your changes

Peer updates changes for proxying only required connections

Provide Issue ticket number if applicable/not in title

Provide testing steps

refer gravitl/netclient#300

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@abhishek9686 abhishek9686 marked this pull request as draft March 29, 2023 07:01
@abhishek9686 abhishek9686 marked this pull request as ready for review March 29, 2023 14:35
theguy951357
theguy951357 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@theguy951357 theguy951357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr steps pass
critical list and state transition tables pass

@afeiszli afeiszli merged commit f48bb19 into develop Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkasun mattkasun mattkasun approved these changes

@afeiszli afeiszli afeiszli approved these changes

@theguy951357 theguy951357 theguy951357 approved these changes

@Aceix Aceix Awaiting requested review from Aceix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhishek9686 @theguy951357 @afeiszli @mattkasun