Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net 137 relays #460

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Net 137 relays #460

merged 3 commits into from
Jun 19, 2023

Conversation

abhishek9686
Copy link
Member

@abhishek9686 abhishek9686 commented Jun 16, 2023

Describe your changes

-> Remove Drop rules
-> Set Foward Policy to Accept by default

Provide Issue ticket number if applicable/not in title

Provide link to Netmaker PR if required

gravitl/netmaker#2401

Provide testing steps

  • Start with a single network
    a. Relay a Node
    b. Relay two Nodes with same Relay Node
    c. while Nodes are being relayed, make a node as a ingress gateway, check whether ext clients are able to reach relayed Nodes
    d. Test egress behind a relay
  • Test relays on multiple networks, with repeating above steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netclient & Netmaker are awesome.

@afeiszli afeiszli merged commit 7fbea17 into develop Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants