Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net-137: Node relays #2401

Merged
merged 10 commits into from
Jun 19, 2023
Merged

Net-137: Node relays #2401

merged 10 commits into from
Jun 19, 2023

Conversation

abhishek9686
Copy link
Member

@abhishek9686 abhishek9686 commented Jun 16, 2023

Describe your changes

-> Revert Relays From Hosts to Nodes
-> Node Level Relay Peer Updates

Provide Issue ticket number if applicable/not in title

Provide testing steps

refer #2401

Test:
Make sure that peers function in all of the various relay scenarios, including

  • 1 relay
  • 2 relays on different machines, on different networks
  • 2 relays on same machine, on different networks
  • egress behind relay
  • ingress to a relay
  • add/remove peers from relay
  • change relayed peer addresses
  • delete relay

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@abhishek9686 abhishek9686 mentioned this pull request Jun 16, 2023
10 tasks
@abhishek9686 abhishek9686 changed the title Net 137 relays Net-137: Node relays Jun 16, 2023
controllers/node.go Outdated Show resolved Hide resolved
logic/nodes.go Show resolved Hide resolved
@afeiszli afeiszli merged commit 6c25826 into develop Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants