Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add label for highway=rest_area and highway=services #575

Closed
Klumbumbus opened this issue May 26, 2014 · 5 comments · Fixed by #941
Closed

Add label for highway=rest_area and highway=services #575

Klumbumbus opened this issue May 26, 2014 · 5 comments · Fixed by #941
Labels
landcover
Milestone
Bugs and improvem...

Comments

@Klumbumbus
Copy link

Names of highway=rest_area and highway=services are not rendered. Is it by design or mistake? They were rendered before switch to carto.

Example rest_area: https://www.openstreetmap.org/way/185327033
Example services: https://www.openstreetmap.org/way/196064179
@Rovastar
Copy link
Contributor

I always tag highway=services as highway=service or highway=unclassifed depending on the roads in the service area.

It is documented in the wiki but with only a few thousand cases so unclear tbh of the real need for this.

@Klumbumbus
Copy link
Author

I do not mean the streets. highway=services is the whole service area, which has the name.

edit: now I understand what you mean..., You tag the area as highway=service. Well, I think you tag it wrong :)

@Rovastar
Copy link
Contributor

ah sorry I didn't realise that. I never never seen it done that way that normally just with a retail landuse and the name of the services in the UK.

How was it rendered before/propose and cannot you just use retail landuse area and it rendered pink and if you do that how would your proposed rendering look?

@Klumbumbus
Copy link
Author

In germany the service areas and rest areas on motorways have names.
Rendering before and after (move the drag button on the bottom):
rest_area: http://bl.ocks.org/tyrasd/raw/6164696/#18.00/50.69369/12.72549
services: http://bl.ocks.org/tyrasd/raw/6164696/#17.00/50.89330/12.94517

@Rovastar
Copy link
Contributor

I see now.
Maybe I just presumed that they were retail landuse as it is the same colour.

@23cpo 23cpo mentioned this issue Jul 14, 2014
Closed
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Sep 12, 2014
@matthijsmelissen
Major rewrite landcover labelling
a471e72 
This commit changes the rendering of landcover labels.

For the purpose of this commit, with 'landcover label' we mean text connected to
a background colour or pattern rendering, and not connected to an icon.

* All rendered landcover tags now have their name rendered (resolves gravitystorm#537). We
  add labels to the following tags:
  * natural=beach,scrub,grassland,heath,sand,desert (partially resolves gravitystorm#788)
  * highway=services,rest_area (resolves gravitystorm#575)
  * aeroway=apron
  * power=station,generator,substation,sub_station
  * tourism=zoo
  * military=barracks
* The minimum zoom level of labels is now defined based on the number of pixels
  rendered (resolves partially gravitystorm#703, resolves gravitystorm#861, resolves gravitystorm#913).
  Labels are rendered from 3000 pixels (but never earlier than the corresponding
  landuse is rendered).
* Font size now also depends on way_pixels. In other words, larger objects get
  a larger label, in three steps (resolves gravitystorm#308).
* Landuse labels are now rendered oblique, to easier visually tell them apart
  from village and POI labels.
* All labels are rendered in a colour similar to the landuse they belong to
  (using landuse color variables, resolves gravitystorm#56). Also some existing colours
  are changed, in order to make them clearly colourful but still readable.
* The text-halo-radius and text-wrap-width properties are made consistent across
  landuse types.
* Font-size, wrap-width an face-name are now defined by easy to change
  variables.
This was referenced Sep 12, 2014
Merged
Closed
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Sep 21, 2014
@matthijsmelissen
Major rewrite landcover labelling
15e5c0e 
This commit changes the rendering of landcover labels.

For the purpose of this commit, with 'landcover label' we mean text connected to
a background colour or pattern rendering, and not connected to an icon.

* All rendered landcover tags now have their name rendered (resolves gravitystorm#537). We
  add labels to the following tags:
  * natural=beach,scrub,grassland,heath,sand,desert (partially resolves gravitystorm#788)
  * highway=services,rest_area (resolves gravitystorm#575)
  * aeroway=apron
  * power=station,generator,substation,sub_station
  * tourism=zoo
  * military=barracks
* The minimum zoom level of labels is now defined based on the number of pixels
  rendered (resolves partially gravitystorm#703, resolves gravitystorm#861, resolves gravitystorm#913).
  Labels are rendered from 3000 pixels (but never earlier than the corresponding
  landuse is rendered).
* Font size now also depends on way_pixels. In other words, larger objects get
  a larger label, in three steps (resolves gravitystorm#308).
* Landuse labels are now rendered oblique, to easier visually tell them apart
  from village and POI labels.
* All labels are rendered in a colour similar to the landuse they belong to
  (using landuse color variables, resolves gravitystorm#56). Also some existing colours
  are changed, in order to make them clearly colourful but still readable.
* The text-halo-radius and text-wrap-width properties are made consistent across
  landuse types.
* Font-size, wrap-width an face-name are now defined by easy to change
  variables.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Sep 22, 2014
@matthijsmelissen
Major rewrite landcover labelling
c0e1a2e 
This commit changes the rendering of landcover labels.

For the purpose of this commit, with 'landcover label' we mean text connected to
a background colour or pattern rendering, and not connected to an icon.

* All rendered landcover tags now have their name rendered (resolves gravitystorm#537). We
  add labels to the following tags:
  * natural=beach,scrub,grassland,heath,sand,desert (partially resolves gravitystorm#788)
  * highway=services,rest_area (resolves gravitystorm#575)
  * aeroway=apron
  * power=station,generator,substation,sub_station
  * tourism=zoo
  * military=barracks
* The minimum zoom level of labels is now defined based on the number of pixels
  rendered (resolves partially gravitystorm#703, resolves gravitystorm#861, resolves gravitystorm#913).
  Labels are rendered from 3000 pixels (but never earlier than the corresponding
  landuse is rendered).
* Font size now also depends on way_pixels. In other words, larger objects get
  a larger label, in three steps (resolves gravitystorm#308).
* Landuse labels are now rendered oblique, to easier visually tell them apart
  from village and POI labels.
* All labels are rendered in a colour similar to the landuse they belong to
  (using landuse color variables, resolves gravitystorm#56). Also some existing colours
  are changed, in order to make them clearly colourful but still readable.
* The text-halo-radius and text-wrap-width properties are made consistent across
  landuse types.
* Font-size, wrap-width an face-name are now defined by easy to change
  variables.
@matthijsmelissen matthijsmelissen changed the title names of highway=rest_area and highway=services not rendered Add rendering for highway=rest_area and highway=services Sep 24, 2014
@matthijsmelissen matthijsmelissen changed the title Add rendering for highway=rest_area and highway=services Add label for highway=rest_area and highway=services Sep 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
landcover
Projects
None yet
Milestone
Bugs and improvements
Development

Successfully merging a pull request may close this issue.

Major rewrite landcover labelling matthijsmelissen/openstreetmap-carto
3 participants
@Rovastar @matthijsmelissen @Klumbumbus